Add a selectionAPI='auto' mode for features. #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the new default. If any feature event is bound on the feature, the selectionAPI is enabled. Binding and unbinding feature events will update the selection. The selectionAPI can still be a boolean to directly control the behavior. This resolves #871.
manthey
force-pushed
the
auto-selection-api
branch
from
261b42e to
677bafe
Compare
aashish24
approved these changes
Sep 27, 2018
waxlamp
approved these changes
Sep 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the new default. If any feature event is bound on the feature, the selectionAPI is enabled. Binding and unbinding feature events will update the selection. The selectionAPI can still be a boolean to directly control the behavior.
This resolves #871.